Results 378 comments of Chris Brown

I'm satisfied that this is ready for merge and release. /cc @mattstauffer

> I'd do it myself, but maintainers aren't allowed to modify this PR. Ya, most projects would close and reject the PR when that flag is set, since it is...

@lat9 would you be open to renaming this slightly, to reduce the plurals so that extra escaping of apostrophes can be avoided? ie: `private string $configGroupTitle = 'Products\\\' Options\\\' Stock...

@MarceauKa One note: since this PR uses a `PHP named argument`, it will require minimum PHP `^8.0`, dropping support for `^7.2`.

I'm not convinced this is the best way to solve this "problem". What I've done for this is simply to block the Impersonate option in the UI if the user...

In `FilesLanguageLoader`, is there an important reason why we're returning `false` when `isFileAlreadyLoaded` returns `true`? https://github.com/zencart/zencart/blob/e924713e98474240beacb5b6957149f5238d70e2/includes/classes/ResourceLoaders/FilesLanguageLoader.php#L46:L48 It would seem that the `loadModuleLanguageFile` method just above is returning `true` if a...

One challenge with this idea is determining whether it applies to "all" products, vs just a select few products.

Aside: language translations can't be added for plugins without manually adding them to a plugin's subdirectory tree, vs directly in the non-zc plugins core directory. And no fallback to English...

@piloujp @lat9 all the `mb_` functions are now available by virtue of polyfills. So, theoretically at least, we should be able to safely convert all/most `substr` to `mb_substr`, and other...

@piloujp I echo lat9's comment: thanks for your detailed analysis. You raised a question about `zen_break_string`: the purpose of this function is to extract a shorter portion of text that...