Chris Brown
Chris Brown
After considering this more, I'm inclined (instead of this PR) to put something in zc_install upgrade script to clean any constants that have trailing spaces. And suggest that the plugin...
Inspection: `SELECT * FROM configuration WHERE configuration_key RLIKE ' ';` Fix: `UPDATE configuration SET configuration_key = RTRIM( configuration_key ) WHERE configuration_key RLIKE ' ';`
The danger in "fixing" this in an automated way is twofold: 1. "activating" things that have been "dormant"/(broken) forever, and would suddenly "start working" unexpectedly, with potentially confusing side-effects. 2....
Hmm. This does its inspection right up front when it checks all the prerequisites and before it detects the ZC version.
> the database's root collation has been changed to utf8mb4_swedish_ci > database's overall collation has been changed to utf8mb4_general_ci Okay, those are expected: it does attempt to set the database's...
This now has enough error messaging and blocks in place that it should prevent users from getting into a bad state. They'll probably wish that the db-converter was built-in though.
Screenshots added to OP.
Does using `125` instead of `71` cause any side-effects?
`usu` loads init_languages at `99` so it's available before init_sanitize which loads at `100`. So, using that example, I *think* this would be safe: - init_paypal_ipn_sessions move to `79` (before...
> You took the PHP version check out of the admin version of html_output.php, but not the storefront version. Was this intended? ? I intentionally added it in both.