Drashna Jaelre
Drashna Jaelre
Also, dynamic macros should probably be disabled for VIA, since via has it's own handling for macros.
Just a heads up, develop has a pretty massive rework of all of the ploopy code, to unify it into a more cohesive base. (#22967) As such, the files that...
Generally, we want two approvals from collaborators or other exports for the PR before it's merged. So, it's mostly a waiting game. And usually, it can take a couple of...
> Regarding tests: I couldn't seem to find any existing tests for mousekeys... so my takeaway was that this area of the code isn't considered critical enough to require tests....
There is a merge conflict here that needs resolving (eg, rebasing)
Honestly, low adoption or not, I'd rather leave these in.
Given the nature of the issue reported, and the complexity, I'd feel a lot better about this code change if unit tests for oneshot layers were added to verify and...
If you have qmk build tools set up, you should be able to run the unit tests. There are some caveats. I know for macOS, it doesn't like the default...
> Windows 11 (Build 22000 or later)
Mostly, it's waiting on a second review, and I've flagged it as awaiting review to help with that.