qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Published 20 hours ago • verified publisher icon qmk

ploopyco: Expose toggle scrolling as a custom keycode

Open beaudrychase opened this issue 9 months ago • 7 comments

Description

The goal of this PR is to allow users to create keymaps with both momentary and toggle control over drag scroll by mapping these functions to two separate custom keycodes. This will allow people to switch between momentary and toggle control of drag scroll through VIA, instead of having to flash new firmware with different macros set.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [x] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [x] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

beaudrychase avatar May 16 '24 13:05 beaudrychase

Just a heads up, develop has a pretty massive rework of all of the ploopy code, to unify it into a more cohesive base. (#22967) As such, the files that you're editing no longer exist on that branch, and this change will cause merge conflicts.

I would recommend rebasing this to target develop instead.

drashna avatar May 18 '24 06:05 drashna

Oh sick, I hadn't seem that PR. Honestly, this was a quick and dirty PR for me to get the functionality I wanted and something to link to in this issue. I can for sure clean this up and rebase on top of that commit you linked.

beaudrychase avatar May 18 '24 18:05 beaudrychase

This is my first time contributing to this project; is there anything I need to do to get this merged in? @drashna I also think this PR is in a done state. @drashna thank you so much for your work on the Ploopy firmware and for taking the time to review this PR.

beaudrychase avatar May 22 '24 00:05 beaudrychase

Generally, we want two approvals from collaborators or other exports for the PR before it's merged.

So, it's mostly a waiting game. And usually, it can take a couple of weeks. There are a lot of PRs, and we all do this in our free time.

drashna avatar May 22 '24 03:05 drashna

That's a sensible policy. Thank you again for all of your efforts!

beaudrychase avatar May 22 '24 03:05 beaudrychase