Drashna Jaelre

Results 149 comments of Drashna Jaelre

Also, most of the commented out code can be removed.

Lint has flagged a few issues. Please resolve.

I'm not sure what the point is here. Adding the labels here doesn't add defaults to the configurator. That needs to be done in the qmk configurator repo.

Yeah, there is an issue with the WPM code right now. IIRC, there is a proposed fix for that. Also, develop seems to handle the split code better.

Also, my tractyl manuform uses sh1107 oled (i2c). Namely, you need to enable the i2c peripherial, and set config, if needed.

> Will squash...this is getting a bit out of hand. No need, we squash when merging, so won't matter either way.

Sorry, that was my bad. I have pushed a fix for it.

@ploopyco would you mind if I take over this PR?

@sigprof that's fine. I think it may still be a good idea to include, but it may be worth adding settings to control the behavior (like "strict bootmagic processing", or...

> I can see the use case for enabling this new behavior with a define, but for the moment my thinking is that the default should behavior should be the...