Daniel Alley comments

Results 427 comments of


                                            Daniel Alley

Support metrics to be exposed for monitoring system like prometheus

A histogram makes sense, [wrk2 provides one](https://github.com/giltene/wrk2). Embedding an entire embedded webserver to host prometheus metrics might be stretching it. Maybe a a separate tool could use `rewrk` as a...

get_objects_for_group expects Group instance and raises error during the django migration

The latest commit to this repo touched this line, so it might be worthwhile to try the dev branch. https://github.com/django-guardian/django-guardian/commit/1c74f2491bd5aba21c8fa9fdcf3cd1cc5c007382

SAT Competition

Looks like the API has stabilized

Can this be made available as a library?

There's a Rust crate that wraps the original minisat library that has basically this exact API: https://github.com/luteberget/minisat-rs It also has a couple of convenient extensions (in Rust) such as the...

Non-streaming decode() appears to remove the BOM?

The same thing happens with the streaming API. Am I missing something? Why does the decoder produced by `new_decoder()` strip the BOM when there is a separate method named `new_decoder_with_bom_removal()`...

Non-streaming decode() appears to remove the BOM?

@hsivonen Is there a detail that I'm missing?

Non-streaming decode() appears to remove the BOM?

I could try to put up a PR, I just want to verify that there's not a reason behind this

Non-streaming decode() appears to remove the BOM?

@hsivonen If what you say is true then the name of `decode_with_bom_removal()` doesn't indicate the actual difference between `decode_with_bom_removal()` and `decode()`. At minimum that is highly confusing. It sounds like...

Non-streaming decode() appears to remove the BOM?

Furthermore I don't see any documentation indicating that `decode()` removes the BOM, could you point out where it is documented?

Non-streaming decode() appears to remove the BOM?

So ignoring the documentation issue, I can understand why this is the case due to the way the WHATWG spec defines how `decode` should be done (though the name "_with_bom_removal()"...