Daniel Alley
Daniel Alley
Although @999eagle, if you could please address the failing test, and rename `IoReader` to `BufferedReader` (I see that the filename has changed, but not the struct name), and fix the...
Thanks! The last thing I think this needs is a changelog entry. Could you please apply ```diff diff --git a/Changelog.md b/Changelog.md index c305325..e1cb297 100644 --- a/Changelog.md +++ b/Changelog.md @@ -137,6...
And @999eagle, I plan to put up a new draft PR in short order with part of those changes, if you have any suggestions about how to adjust the `check!`...
What I ended up doing, was just move those tests outside of the macro since they don't make sense for both implementations.
The issue is, at least regarding the decoding work, if there's no inner struct then there's nowhere to put the buffer(s?) and other related data for decoding - so it...
@999eagle In practical terms, hold off on rebasing the PR further until there's a consensus on the architecture. I think what we may end up doing is pulling the commits...
> also think that implementations between the (what's now called) BufferedReader and a potential new AsyncBufferedReader are very likely to be similar enough to allow them to be implemented through...
The trimming of spaces within elements probably ought to be separated from the trimming of spaces between elements. It should be possible (and probably the default) to ignore the latter...
Not sure that the checklist needs to include things that are already checked by the CI?
Will need a few days to fully review.. just leaving a few comments for now.