Daniel Alley

Results 427 comments of Daniel Alley

I really wish we could try out the internal buffering idea (no more `read_event_into()`, `&str` returned in all cases) before introducing all these macros, as I think there may be...

@999eagle Do you feel like this feature is living up to your expectations? Any issues with it in practice?

Update, partially tempering my own expectations: One issue is that each node stores a full copy of the key - that has already been noted previously in other issues. But...

Preview ![image](https://user-images.githubusercontent.com/2751996/176348885-83e8b4b8-79a2-42f2-a821-ddacb4438d86.png)

Yes, and it only requires about 3 lines of change. I'm going to see if it can be improved any further and whether the occasional regressions can be eliminated.

This may be related to https://github.com/tafia/quick-xml/pull/205

@ozgrakkurt I can't find any PR for this, have you opened one?

Never came across it, no. I'll take a look.

This library looks nice, there are a few limitations to think about how to work around (or not), but it does enough of the right things that I'll use it...

> But after this PR we should perform decoding only for buffered case (because borrowed case will read from &str, right?) Yes but that's not really the issue I'm describing,...