Dave Protasowski
Dave Protasowski
For `unused-parameter` I say we disable it in in our config here - https://github.com/knative/serving/blob/main/.golangci.yaml I think the PRs for that will be noisy and wont really improve anything eg. then...
@prashantrewar go for it
CI is failing - see the GitHub checks - I'll wait for them to go green before reviewing again
Hey @yp969803 the unit tests that are failing is the code you've modified can you take a look?
Going to close this out due to inactivity.
Something to explore is what's happening with the knative resources and knative controllers - since if our labeler marked the older revision as reserve then it would scale down accordingly....
Added this to the current milestone since I know you're actively working on it 💪
I think the other thing to note is typically we want the revision to scale up to 1 (initial-scale) to ensure it's working. And if you're not aware we have...
/assign @andrew-delph Coming back to this with fresh eyes - repeating the original problem statement > See that rev-00001 will not scale down until progressDeadline is reached I'm wondering now...