Validation added for initialScale greater than maxScale (#14153)

[yp969803]

Fixes #14153

Proposed Changes

• Added a validation for initialScale > maxScale
• As initialScale > maxScale not making sense at all. As it is not depending on traffic.

Release Note

none

[knative-prow[bot]]

Hi @yp969803. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dprotaso]

/ok-to-test

[yp969803]

@dprotaso i have added the further annotations can you review

[codecov[bot]]

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (81149da) 86.05% compared to head (2579cc1) 85.81%. Report is 39 commits behind head on main.

:exclamation: Current head 2579cc1 differs from pull request most recent head 6ef38fa. Consider uploading reports for the commit 6ef38fa to get more accurate results

Files	Patch %	Lines
pkg/apis/autoscaling/annotation_validation.go	0.00%	29 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14682      +/-   ##
==========================================
- Coverage   86.05%   85.81%   -0.24%     
==========================================
  Files         197      197              
  Lines       14937    14974      +37     
==========================================
- Hits        12854    12850       -4     
- Misses       1774     1810      +36     
- Partials      309      314       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yp969803 Once this PR has been reviewed and has the lgtm label, please ask for approval from dprotaso. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[yp969803]

@dprotaso i have updated the pr you can review, adding test is left

[yp969803]

@dprotaso updated the pr and added the unit test

[knative-prow[bot]]

@yp969803: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
unit-tests_serving_main	6ef38fadfe8db039f3ee9f9f6a6531014458475f	link	true	/test unit-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[yp969803]

@dprotaso any stuff left?

[dprotaso]

CI is failing - see the GitHub checks - I'll wait for them to go green before reviewing again

[dprotaso]

Hey @yp969803 the unit tests that are failing is the code you've modified can you take a look?

[dprotaso]

Going to close this out due to inactivity.