Dave Protasowski
Dave Protasowski
Given a migration we might want consider re-working some things - eg. https://github.com/knative-extensions/net-certmanager/issues/353
also related: https://github.com/knative/operator/issues/1621#issuecomment-1911684744
I've been reviewing https://github.com/knative/serving/pull/14607 & https://github.com/knative/serving/pull/14573 which address bugs in the same part of the codebase as this PR. Those PRs fix the problem but they would introduce regressions if...
/hold cancel /lgtm
linter failed - I just updated the PR to use the right `ptr` package /lgtm
kourier-tls flakes - https://github.com/knative/serving/issues/15052 /retest
sounds good let's do it in a follow up /lgtm /approve
> Creating cluster kt2-976cbdbf-d8bf-4f25-98d2-336e3751a-1 in us-central1... > knative-boskos-17 https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_serving/14938/upgrade-tests_serving_main/1760984226880032768
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_serving/14937/istio-latest-no-mesh-tls_serving_main/1760984197540876288 > knative-boskos-81 > kt2-69a9f6d8-0e87-4473-8de4-17240548b-1 in us-central1...