serving icon indicating copy to clipboard operation
serving copied to clipboard

Discussion: do we want to keep net-certmanager or can we integrate in Serving

Open ReToCode opened this issue 2 years ago • 5 comments

Relates to the discussion in https://github.com/knative/serving/issues/14720.

Overall, it begs the question if we even need net-certmanager as a separate component and the KnativeCertificate abstraction. When http01 is deprecated and removed, there is only one implementation left.

Arguments

  • Mainly maintainability: we are only three active people maintaining a lot of repos --> just bumping, updating generators and stuff is a lot of work
  • Easier to install and configure:
    • People do not need to install and additional component in YAML
    • The installation in operator is not solved: https://github.com/knative/operator/issues/950
  • Eventing uses cert-manager directly
  • We can have a separate controller in Serving-controller, only starting when encryption is enabled and cert-manager CRDs are present

@skonto please add more points and link to upcoming Serving WG meeting.

ReToCode avatar Dec 20 '23 08:12 ReToCode

I would add:

  • net-certmanager does not do much, basically it translates Knative certificates to cert-manager certificates. Given that Eventing integrates with cert-manager directly, I think that the right abstraction to integrate is that of a configmap/secret. Most projects out there do the latter. Not sure why Serving needs to do more as long as steps are documented we should be fine.
  • Serving already has several deployments and we should consider simplifying the deployment model.

skonto avatar Dec 20 '23 10:12 skonto

I think integrating makes sense - let's formalize a plan - cause we'll need a migration path for existing users

dprotaso avatar Jan 31 '24 16:01 dprotaso

Given a migration we might want consider re-working some things - eg. https://github.com/knative-extensions/net-certmanager/issues/353

dprotaso avatar Jan 31 '24 16:01 dprotaso

also related: https://github.com/knative/operator/issues/1621#issuecomment-1911684744

dprotaso avatar Jan 31 '24 16:01 dprotaso

/assign @skonto

skonto avatar Feb 20 '24 13:02 skonto