Dave Protasowski

Results 1317 comments of Dave Protasowski

adding approvers /assign @arkodg @mlavacca @sunjayBhatia adding reviewers /cc @LiorLieberman @michaelbeaumont @Xunzhuo

Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @sunjayBhatia @michaelbeaumont @LiorLieberman @Xunzhuo

I've added back all the test cases for the regular filter. The backend filter has a subset of these cases.

> has this been tested against any implementation ? I ran these tests against Istio. The backendRef variant fails as expected because they don't support that feature.

> imo lets add conformance tests if at least 1 implementation supports this case. But then an implementation can't advertise the support this feature on the GatewayClass. They'll have to...

Also the test is identical to the pre-split filter - so for this case I wouldn't be concerned with stability of the conformance test.

Linter is unblocked by https://github.com/kubernetes-sigs/gateway-api/pull/2829

/assign @arkodg @mlavacca @sunjayBhatia /cc @LiorLieberman @michaelbeaumont @Xunzhuo

Rebased and added an exclude option for a linter that has a false positive The linter has a fix in a newer version but it's not part of the latest...