Dave Protasowski
Dave Protasowski
Honestly the right fix seems to be to introduce the validation back once controller tools has fixed their alias support for overriding markers
We also had to adjust the min/max marker as well because it didn't look at underlying types and just dropped markers See: https://github.com/kubernetes-sigs/gateway-api/blob/9098973c15bd56601074fe36ab33bbf3e83964db/pkg/generator/markers.go#L31
> Nit Yup > What benefit does having to cast all int32s to a PortNumber type provide for Go authors at the moment? I'm assuming it was for the validation...
/hold Made a comment here - https://github.com/knative/pkg/pull/3164#issuecomment-2800126864 I want to revisit our OTel approach after the next release. That might require breaking changes and we'd probably make this change without...
Our OTel migrations have landed - and we use the service name if it's associated with one
Note I also refactored a bunch so the tests can be run downstream a bit more easily without a whole lot of boilerplate /assign @shaneutt @mlavacca
Also if we don't like this direction then I think it would be good to keep some of the refactor then it would be possible for downstream to run the...
Few of the comments mentioned dropping the legacy support in this PR. I suggest we do this in a follow up PR. It'll be easier to understand the changes that...
@mlavacca take a look now
/kind cleanup /kind test /area conformance