Dave Protasowski
Dave Protasowski
@V0YD23 sure - can you write something up before you do any implementation
Curious besides the condition being incorrect do you see any other issues?
/assign @youngnick - who's working on this now
/assign @dprotaso
/assign @joerober
/hold This should be merged after 1.2 is cut - See: https://github.com/kubernetes-sigs/gateway-api/pull/3108#issuecomment-2130155616
This is general problem - I'm noticing even a type aliases for int types break different markers eg. the min/max markers check the type to be an integer. https://github.com/kubernetes-sigs/controller-tools/blob/23dd517d714eb79eb9fac3d51485b09189e3f742/pkg/crd/markers/validation.go#L329 When...
So these markers need to recurse these references or maybe they need to be flattened?
The checks aren't required - but I wouldn't assume tide would merge while there were actions in a 'running' state
/lifecycle frozen I just encountered a related scenario. Opened a PR against a release branch where we have no prow jobs. We do have gating github actions that should prevent...