Dave Protasowski
Dave Protasowski
So Knative by default sets the terminationGracePeriod to the revision's timeoutseconds. This handles the scenario where a request comes in around the time the pod is being terminated - thus...
Ok - I found the KEP and it explained the use https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2238-liveness-probe-grace-period#summary Yeah I think this makes sense to support. From the KEP the TerminationGracePeriod in the probe is used...
> Do you see a use case to make it configurable for the queue-proxy too ? I don't believe we set a liveness probe on the queue proxy so we...
> I hope that it's pretty easy and no google doc is needed. I'd prefer a more flushed out proposal for this feature see: https://github.com/knative/community/blob/main/mechanics/FEATURE-TRACKS.md The goal of the proposal...
/triage accepted yeah this has caused confusion in the past
@thiagomedina sure /assign @thiagomedina
@thiagomedina related to this is what happens when the request is cancelled https://github.com/knative/serving/issues/13746
What's the harm in running the h2c server on a second port?
@shaneutt I'd close this out and the PR - the servers listen on different ports and I don't feel it's impacting conformance tests in a meaningful way. Unless I'm mistaken...