Damien George
Damien George
@andrewleech I see you made changes. Is this ready for re-review?
@andrewleech I see you made changes. Is this ready for re-review?
I tested this on a FeatherS2 with ESP32_GENERIC_S2 firmware. I can get a REPL but it's easy to lock it up, eg by typing "help()" at the prompt: ``` $...
I also tested a TinyS3 with ESP32_GENERIC_S3 firmware, and it's also easy to lock up, eg with `help()`, or running the test suite eg `tests/basics/int_big1.py` fails.
> TLDR stdout was releasing the gil for larger transfers, which made sense when IDF was doing it completely itself. Now there's more micropython interaction and idle sleeps it certainly...
I've tested this on an S2 and S3 and it's looking a lot better. I have a test which tests throughput (and integrity) of the USB CDC. Prior to this...
@andrewleech can you please rebase this on latest master, which has had some changes, eg due to #15727. Then it should be ready for final review and merge.
Let's update TinyUSB to 0.17.0 separately in #15902.
@andrewleech can you please rebase on latest master to pick up the tinyusb update. Then hopefully that's the final bit!
> I'm not sure if I should just enable the runtime support defines here by default for the S2 and S3 Let's leave that for a separate PR.