dpc

Results 818 comments of dpc

I arrived here to ask about combining MNC with cachix as well. We're using cachix already, and it works well, but maybe there's room for improvements still. > In general,...

We have a somewhat [extensive CI pipeline](https://github.com/fedimint/fedimint/actions/runs/5482560783) building large Rust project natively, running tests as Nix derivations, cross-compiling to various platforms, and all sorts of things.

Correction: It seems that tracing_subscriber does use string prefix based matching so `RUST_LOG=AlephBFT-=off` might actually work. But it still seems to me that keeping it module-like is ideal.

> You should be able to implement the `Async*` traits for your `Backup*` structs with no major problems, although maybe parts of them will look a tad awkward "tad awkward"...

> this poll dance for async write doesn't look trivial. > I don't think it is possible to convert `async fn save(&self, &mut [u8])` into async write, because caller can...

http://pubs.opengroup.org/onlinepubs/9699919799/functions/sigpending.html maybe could be used instead?

Part of the reason why core `slog` is a bunch of modular crates is that there is an infinite number of ways to glue together non-trivial logging setups. That's also...

@vorot93 I'm not aware of "coat rack" phrase, but if you mean that I link to the review to increase visibility to increase the awareness of it, then it's true....

> but it would probably have been better to just put the connector in a Client object :+1: Oh so, `InfoType` is for free-form `fileInfo`. I'd just hardcode it to...