dpc

icon indicating a website link http://dpc.pw icon indicating an email [email protected]

icon location CA, USA icon location Born 1985, programming since ~1993, on Linux ~1998, professionally ~2003, on github ~2008, with Rust ~2013. Deep&wide generalist, FOSS enthusiast.

Results 818 comments of dpc

A future-based drain for the asynchronous future

AFAIK, `slog-async` already doesn't block unless you tell it to https://docs.rs/slog-async/2.6.0/slog_async/enum.OverflowStrategy.html

A future-based drain for the asynchronous future

AFAIK, yes.

question: How to flush on a async logger?

Can't really flush an async logger, as it can't not control the receiver on the other side of a channel. The closest thing we could have is maybe waiting for...

question: How to flush on a async logger?

Ah. I'm silly. You are logging with slog-async, and then you might want to display prompt etc. on stderr . It seems like a legitimate use case... Under the hood...

question: How to flush on a async logger?

Most ecosystem expects `Drain` already, so it would have be a new method on an existing trait with an default impl that does something reasonable (like signals lack of support...

fix: Implement `flush` function on `Async`

Looks reasonable to me. Ping @Techcable as current maintainer.

Replace crossbeam-channel by flume

Well... I'm not sure what to do about it. :D

Replace crossbeam-channel by flume

So... all agree that `flume` is better? :D

Replace crossbeam-channel by flume

Could be a config (feature) option.

Replace crossbeam with std::sync::mpsc

Why? We've just changed to `crossbeam` cuz it's better.