Doug Bunting

Results 268 comments of Doug Bunting

Changes appear incomplete ``` text D:\a\_work\1\s\src\Servers\IIS\IISIntegration\src\Microsoft.AspNetCore.Server.IISIntegration.csproj : error NU1605: Detected package downgrade: System.Buffers from 4.5.1 to 4.5.0. Reference the package directly from the project to select a different version. [C:\Program...

> we also need to turn `UseLatestPackageReferences` on globally This feels like a sledgehammer when a small hammer would have done the trick. First, the external versions from the baselines...

> This might just be the only such case currently. For now, please limit the fix to the currently-failing case e.g. set `$(UseLatestPackageReferences)` to `true` just in Microsoft.AspNetCore.Server.IISIntegration.csproj. The settings...

> That seems like a band-aid, if the scenario I described above is accurate then it seems like globally using latest package references would be the right thing For release/2.1,...

My concern here is about greatly expanding the scope of this change. Please add lots of comments pointing people to the targeted fix (much nicer term than Band-Aid 😄)

Suspect a number of test sites are having trouble starting. The build logs aren't particularly clear unfortunately.

Now rebased on latest release/2.1. That meant no changes were required in src/SignalR/clients/ts/webdriver-tap-runner

>so I'm thinking that these tests are picking up a behavioral change that they weren't before since we're resolving newer references now /fyi @halter73 @HaoK: In release/2.1, all non-implementation projects...

In case it's not obvious, the [[C&AI Translation Feedback] - ASP.NET Core incomplete German translation](https://dev.azure.com/ceapex/CEINTL/_workitems/edit/710128) fix is in the dotnet/spa-templates repo but that doesn't affect what we ship until the...