aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

[release/7.0] Update spa-templates to ref new 7.0 branch

Open dougbu opened this issue 3 years ago • 2 comments

[release/7.0] Update spa-templates to ref new 7.0 branch

Description

  • just created release/7.0 in dotnet/spa-templates
    • use it here to enable main in spa-templates to get new branding
  • also use latest commit from spa-templates

Contains a fix for [C&AI Translation Feedback] - ASP.NET Core incomplete German translation. #43956 brings in fixes for the templates in dotnat/aspnetcore for that bug too (more on that when that loc handback PR is in main and ready for backporting).

Customer Impact

Without this fix, customer would see Target net7.0 instead of Ziel net7.0 when in a German locale and using one of the templates from Microsoft.DotNet.Web.Spa.ProjectTemplates.7.0.

Regression?

  • [ ] Yes
  • [x] No

Microsoft.DotNet.Web.Spa.ProjectTemplates.6.0 only had translations for the name and description of the two templates from dotnet/spa-templates. This change here completes filling that gap.

Risk

  • [ ] High
  • [ ] Medium
  • [x] Low

One-word changes in existing language-specific files 😃

Verification

  • [x] Manual (required)
  • [ ] Automated

Packaging changes reviewed?

  • [ ] Yes
  • [ ] No
  • [x] N/A

dougbu avatar Sep 22 '22 22:09 dougbu

Hi @dougbu. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

ghost avatar Sep 22 '22 22:09 ghost

In case it's not obvious, the [C&AI Translation Feedback] - ASP.NET Core incomplete German translation fix is in the dotnet/spa-templates repo but that doesn't affect what we ship until the submodule is updated here.

dougbu avatar Sep 22 '22 22:09 dougbu

/azp run

dougbu avatar Sep 23 '22 22:09 dougbu

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Sep 23 '22 22:09 azure-pipelines[bot]

Approved in email

dougbu avatar Sep 24 '22 01:09 dougbu