Daniel Orner
Daniel Orner
@nathangthomas are you still interested in finishing this?
I don't think that's possible since we crash *inside* the `to_a` method. I'm not worried about this one, but definitely OK to merge after the release.
Going to close this - no activity and based on the comments it was not taking the right approach.
@cielf can this one go in?
If you're using disable\_with, why do you need all the rest of it? Check something like this [https://stackoverflow.com/a/76288769/5199431](https://stackoverflow.com/a/76288769/5199431) - there should be a really easy way to accomplish this.
Yeah. My concerns with using factory values are: 1. It's brittle. If the factory ever changes, all the specs break and have to be changed as well. 2. It's confusing....
The PRs around this were more around making sure we don't create data that we don't need. This is more about not *checking* values that we didn't create ourselves. They...
@jimmyli97 I hope you aren't putting all the factory rework and the kit changes together? They need to be separate. Also, I'm not sure the factories themselves need to change,...
ah ok - so it's less about fixing the factories and more about using them to help detect tests which need to change. 👍