human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard
verified publisher icon rubyforgood

Remove to_a method

Open dorner opened this issue 1 year ago • 5 comments

We've had this running in prod for a few weeks without issues. Time to drop the bomb and make it so we can actually do upgrades to Rails!

dorner avatar Mar 31 '24 14:03 dorner

Just a naive question here -- we have been running it with the appropriate flag set for a few weeks, right? I'm pretty sure the flag didn't get set immediately when we pushed the related PR.

cielf avatar Apr 01 '24 19:04 cielf

Yep. I set it on prod.

dorner avatar Apr 01 '24 19:04 dorner

image

dorner avatar Apr 01 '24 19:04 dorner

I'm being paranoid here - In principle, sure! But I'd still like to postpone it to after this weekend's release -- I really want to get the Donation Sites reactivation in. (Edit: and I just have a oogie feeling in case this one has anything wrong with it -- if there's a call that wasn't behind the flag or something)

cielf avatar Apr 04 '24 21:04 cielf

I don't think that's possible since we crash inside the to_a method.

I'm not worried about this one, but definitely OK to merge after the release.

dorner avatar Apr 05 '24 19:04 dorner

@cielf can this one go in?

dorner avatar May 24 '24 20:05 dorner

I think so -- I think we just neglected to actually merge it after the release.

cielf avatar May 24 '24 21:05 cielf