Donald Raab comments

Results 115 comments of


                                            Donald Raab

Optimize primitive collect methods for primitive Bags when collecting into a primitive Bag.

Hi @shreyateeza, any update on this? Let me know if you will be working on it.

Optimize primitive collect methods for primitive Bags when collecting into a primitive Bag.

This is a great point @mohrezaei. The optimization would require the function to be stable and repeatable for the same input. This might mean we have some other places where...

Optimize primitive collect methods for primitive Bags when collecting into a primitive Bag.

Yes, this optimization is flawed @LuizFrra so we should probably remove this optimization on the object side side as well. Another option would be to add a specialized method, possibly...

Optimize primitive collect methods for primitive Bags when collecting into a primitive Bag.

Hi @LuizFrra, yes, this looks correct to me. I think once we add `collectOccurrences`, we should have `countBy` on `Bag` use it instead of `collect` so the optimization can continue...

Optimize primitive collect methods for primitive Bags when collecting into a primitive Bag.

> Proposing, that we name this method `collectEachOccurrences` so it reflects that we are iterating/looping? This works for me, as it makes the distinction clearer between `collectWithOccurrences`.

Implement MapIterable.collectKeysUnique().

Perhaps call it collectKeysUnique if it is going to throw?

Add toStack to Ordered Primitive Iterable

Hi @DineshPurushothamacharya, I'd like to help get this PR reviewed and merged. There are a couple of changes to start with since this PR has been open for a couple...

Add toStack to Ordered Primitive Iterable

Hi @DineshPurushothamacharya, looks like you have some actual issues to fix reported by the checkstyle build. Also, the EclipseFdn ECA check is failing. Do you have a signed ECA on...

Add toStack to Ordered Primitive Iterable

Hi @DineshPurushothamacharya, I am reviewing now. Thank you for your patience!

Add toStack to Ordered Primitive Iterable

Hi @DineshPurushothamacharya, I was hoping to save you the trouble of rebasing your PR and tried using the GitHub Update Branch button for my first time. Unfortunately I did not...