dongjiang

Results 81 comments of dongjiang

> Thanks for doing this! We need to add validation methods to pkg/alertmanager/validation to prevent incompatible settings. Prevent incompatible check maybe add in #6861 . Did I understand it something...

> #6681 adds the validation at the last stage (when the operator aggregates the raw configuration from the secret with the AlertmanagerConfig objects). What I'm talking about here is the...

TODO list: - [ ] adding proxy support in OAuth2 config. - [x] supporting new proxy fields into the AlertmanagerConfig CRD for the HTTP clients. #6864 - [x] supporting new...

> TODO list: > > * [ ] adding proxy support in OAuth2 config. > * [x] supporting new proxy fields into the AlertmanagerConfig CRD for the HTTP clients. [feat:...

> should we create a custom type and embed it in each struct (probe, podmonitor and servicemonitor)? Thanks @simonpasquier . Got it. I'll fix it.

@simonpasquier @slashpai PTAL, thanks

@simonpasquier Please re-check it, thanks.