prometheus-operator icon indicating copy to clipboard operation
prometheus-operator copied to clipboard

feat: support add native histogram config

Open dongjiang1989 opened this issue 1 year ago • 2 comments

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Close: #6774 support add native histogram config

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • [ ] CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • [x] FEATURE (non-breaking change which adds functionality)
  • [ ] BUGFIX (non-breaking change which fixes an issue)
  • [ ] ENHANCEMENT (non-breaking change which improves existing functionality)
  • [ ] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

support add native histogram config

dongjiang1989 avatar Aug 02 '24 10:08 dongjiang1989

should we create a custom type and embed it in each struct (probe, podmonitor and servicemonitor)?

Thanks @simonpasquier . Got it. I'll fix it.

dongjiang1989 avatar Sep 19 '24 11:09 dongjiang1989

@simonpasquier @slashpai PTAL, thanks

dongjiang1989 avatar Oct 17 '24 11:10 dongjiang1989

@simonpasquier Please re-check it, thanks.

dongjiang1989 avatar Oct 21 '24 08:10 dongjiang1989