dongjiang

Results 81 comments of dongjiang

> New changes are detected. LGTM label has been removed. @jasonliu747 addressed comments, please review :)

All replaces are disallowed when using "go install" with a version number, regardless of what kind they are; see https://github.com/golang/go/issues/40276, specifically the sections about "replace".

thanks @discordianfish. Please re-check

@SuperQ Please recheck it, thanks.

> The general idea also applies to the other metrics. We need to carefully think about the names since changing them in the future is a breaking change that will...

@discordianfish Please re-check, thanks https://github.com/prometheus/node_exporter/pull/2827/commits/8b5605040ae8f57566211fd7e557dc12363f5965

> Better, thanks! Still, can you consider combining some of these metrics using the same name and different labels? Thanks for your review. Do you have any suggestions to combine...

Need to add parsing to proc first, and then add metrics to node exporter. Procfs PR: https://github.com/prometheus/procfs/pull/580

`--no-collector.thermal` disable on M1, M2, M3 ``` dongjiang@MacBook Pro:prometheus-operator $ pmset -g thermlog Note: No thermal warning level has been recorded Note: No performance warning level has been recorded Note:...