Donald Sharp

Results 137 comments of Donald Sharp

The rule is that you don't have to fix something you don't touch but if you add new code it must conform to our standard. The tool is telling you...

https://github.com/FRRouting/frr/pull/14183 -> Please use this as a foundation for the route map matching and create a match that is not stored in the nexthop, it is stored as a flag...

This test does not even pass when run in our CI. When I ran it locally it failed consistently too.

any particular reason this is WIP? I don't see a reason to not pull this in

So can you please read workflow.rst and get the commits labeled correctly. Also why does a file need to have vyos in the name? What does the name with vyos...

I agree w/ @sworleys -> this is something that should be done with the lua event hooks system already in place. We need agreement in general that this is the...

In what way is 0:254 wrong in your opinion? What leads you to this conclusion?