frr icon indicating copy to clipboard operation
frr copied to clipboard

Published 20 hours ago • verified publisher icon FRRouting

[WIP] QPPB | QoS Policy Propagation via BGP (using XDP/BCC/BPF)

Open volodymyrhuti opened this issue 2 years ago • 20 comments

Draft pull request with the latest draft of QPPB implementation. The progress and documentation are tracked at VyOS phabricator - T4180

volodymyrhuti avatar Feb 09 '23 09:02 volodymyrhuti

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9598/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch: see merge log in attachment https://ci1.netdef.org/browse/FRR-PULLREQ2-9598/artifact/CHECKOUT/ErrorLog/log_merge.txt

NetDEF-CI avatar Feb 09 '23 09:02 NetDEF-CI

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 09 '23 10:02 github-actions[bot]

So can you please read workflow.rst and get the commits labeled correctly. Also why does a file need to have vyos in the name? What does the name with vyos provide us ?

donaldsharp avatar Feb 10 '23 13:02 donaldsharp

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found
Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found
Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found
Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: No useful log found
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found
Successful on other platforms/tests
  • FreeBSD 12 amd64 build
  • Redhat 8 amd64 build
  • Fedora 29 amd64 build
  • OpenBSD 7 amd64 build
  • FreeBSD 11 amd64 build
  • CentOS 7 amd64 build
  • Redhat 9 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found
Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found
Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found
Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: No useful log found
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found 
Report for bgp_qppb_private.c | 8 issues
===============================================
WARNING: Block comments use a trailing */ on a separate line
#24: FILE: /tmp/f1-1709702/bgp_qppb_private.c:24:
+ * }; */

ERROR: space prohibited before that close parenthesis ')'
#90: FILE: /tmp/f1-1709702/bgp_qppb_private.c:90:
+		 .init = bgp_qppb_module_init, );
Report for bgp_route.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #10852: FILE: /tmp/f1-1709702/bgp_route.c:10852:
Report for bgp_zebra.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #1464: FILE: /tmp/f1-1709702/bgp_zebra.c:1464:
Report for dscp.c | 4 issues
===============================================
ERROR: space required after that close brace '}'
#21: FILE: /tmp/f1-1709702/dscp.c:21:
+	{"voice-admit", DSCP_VOICE}};
Report for routemap_northbound.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #1462: FILE: /tmp/f1-1709702/routemap_northbound.c:1462:
< WARNING: line over 80 characters
< #1463: FILE: /tmp/f1-1709702/routemap_northbound.c:1463:
< WARNING: line over 80 characters
< #1467: FILE: /tmp/f1-1709702/routemap_northbound.c:1467:
Report for xdp_qppb.c | 149 issues
===============================================
ERROR: spaces required around that ':' (ctx:VxW)
#22: FILE: /tmp/f1-1709702/xdp_qppb.c:22:
+#warn XXX: Poor config
          ^

WARNING: C99 // comments do not match recommendation
#54: FILE: /tmp/f1-1709702/xdp_qppb.c:54:
+//               type : key :  leaf : name : size : pin_dir : flags

WARNING: line over 80 characters
#55: FILE: /tmp/f1-1709702/xdp_qppb.c:55:
+BPF_TABLE_PINNED("percpu_array", u32, struct datarec, xdp_stats_map, XDP_ACTION_MAX, STAT_PIN);

WARNING: line over 80 characters
#56: FILE: /tmp/f1-1709702/xdp_qppb.c:56:
+BPF_TABLE_PINNED("lpm_trie", struct lpm_key4, u8, dscp_map, 10240, DSCP_PIN, BPF_F_NO_PREALLOC);

WARNING: line over 80 characters
#57: FILE: /tmp/f1-1709702/xdp_qppb.c:57:
+BPF_TABLE_PINNED("array", u32 /*iface_id*/, u32 /*qppb_bgp_policy*/, qppb_mode_map, 64, QPPB_PIN);

WARNING: C99 // comments do not match recommendation
#58: FILE: /tmp/f1-1709702/xdp_qppb.c:58:
+//               XXX: choose table size limits (read them from sysctl?)

WARNING: Missing a blank line after declarations
#74: FILE: /tmp/f1-1709702/xdp_qppb.c:74:
+	struct datarec *rec = xdp_stats_map.lookup(&action);
+	if (!rec)

ERROR: code indent should use tabs where possible
#85: FILE: /tmp/f1-1709702/xdp_qppb.c:85:
+        __u32 check = bpf_ntohs((__be16)iph->check);$

WARNING: please, no spaces at the start of a line
#85: FILE: /tmp/f1-1709702/xdp_qppb.c:85:
+        __u32 check = bpf_ntohs((__be16)iph->check);$

ERROR: trailing statements should be on next line
#90: FILE: /tmp/f1-1709702/xdp_qppb.c:90:
+	if ((check+1) >> 16) check = (check+1) & 0xffff;

WARNING: Missing a blank line after declarations
#106: FILE: /tmp/f1-1709702/xdp_qppb.c:106:
+	struct meta_info *meta;
+	rc = bpf_xdp_adjust_meta(ctx, -(int)sizeof(*meta));

ERROR: code indent should use tabs where possible
#128: FILE: /tmp/f1-1709702/xdp_qppb.c:128:
+                goto aborted;$

WARNING: please, no spaces at the start of a line
#128: FILE: /tmp/f1-1709702/xdp_qppb.c:128:
+                goto aborted;$

WARNING: line over 80 characters
#137: FILE: /tmp/f1-1709702/xdp_qppb.c:137:
+		bpf_trace_printk("XDP ignore marked packet [%d|%d]", iph->tos, meta->mark);

ERROR: switch and case should be at the same indent
#163: FILE: /tmp/f1-1709702/xdp_qppb.c:163:
+	switch (qppb_mode) {
+		case BGP_POLICY_DST:
[...]
+		case BGP_POLICY_SRC:
[...]
+		default:

WARNING: char * array declaration might be better as static const
#191: FILE: /tmp/f1-1709702/xdp_qppb.c:191:
+	const char *MODES[] = { "MARK_SKB\0", "MARK_META\0", NULL };

WARNING: Missing a blank line after declarations
#192: FILE: /tmp/f1-1709702/xdp_qppb.c:192:
+	const char *MODES[] = { "MARK_SKB\0", "MARK_META\0", NULL };
+	bpf_trace_printk("Mode [%s]\n", MODES[0]

WARNING: space prohibited between function name and open parenthesis '('
#195: FILE: /tmp/f1-1709702/xdp_qppb.c:195:
+	Lookslike bpf version of printk handles only first string arguments (?)

ERROR: spaces required around that '?' (ctx:BxB)
#195: FILE: /tmp/f1-1709702/xdp_qppb.c:195:
+	Lookslike bpf version of printk handles only first string arguments (?)
 	                                                                     ^

WARNING: C99 // comments do not match recommendation
#197: FILE: /tmp/f1-1709702/xdp_qppb.c:197:
+		https://nakryiko.com/posts/bpf-tips-printk/

ERROR: spaces required around that ':' (ctx:VxE)
#197: FILE: /tmp/f1-1709702/xdp_qppb.c:197:
+		https://nakryiko.com/posts/bpf-tips-printk/
 		     ^

ERROR: spaces required around that ':' (ctx:VxW)
#200: FILE: /tmp/f1-1709702/xdp_qppb.c:200:
+out:     return xdp_stats_record_action(ctx, action);
    ^

WARNING: C99 // comments do not match recommendation
#202: FILE: /tmp/f1-1709702/xdp_qppb.c:202:
+aborted: return xdp_stats_record_action(ctx, XDP_ABORTED);  // packet is dropped

ERROR: spaces required around that ':' (ctx:VxW)
#203: FILE: /tmp/f1-1709702/xdp_qppb.c:203:
+skip:    return action;
     ^

WARNING: C99 // comments do not match recommendation
#212: FILE: /tmp/f1-1709702/xdp_qppb.c:212:
+	// Default priority

WARNING: C99 // comments do not match recommendation
#214: FILE: /tmp/f1-1709702/xdp_qppb.c:214:
+	// Check XDP gave us some data_meta

ERROR: "(foo*)" should be "(foo *)"
#215: FILE: /tmp/f1-1709702/xdp_qppb.c:215:
+	if ((void*)(meta + 1) > data)

ERROR: switch and case should be at the same indent
#222: FILE: /tmp/f1-1709702/xdp_qppb.c:222:
+	switch(meta->mark >> 2) {
+		case 10: skb->tc_classid = 0x10; break;
+		case 20: skb->tc_classid = 0x20; break;
+		case 30: skb->tc_classid = 0x30; break;
+		case 40: skb->tc_classid = 0x40; break;

ERROR: space required before the open parenthesis '('
#222: FILE: /tmp/f1-1709702/xdp_qppb.c:222:
+	switch(meta->mark >> 2) {

ERROR: trailing statements should be on next line
#223: FILE: /tmp/f1-1709702/xdp_qppb.c:223:
+		case 10: skb->tc_classid = 0x10; break;

ERROR: trailing statements should be on next line
#224: FILE: /tmp/f1-1709702/xdp_qppb.c:224:
+		case 20: skb->tc_classid = 0x20; break;

ERROR: trailing statements should be on next line
#225: FILE: /tmp/f1-1709702/xdp_qppb.c:225:
+		case 30: skb->tc_classid = 0x30; break;

ERROR: trailing statements should be on next line
#226: FILE: /tmp/f1-1709702/xdp_qppb.c:226:
+		case 40: skb->tc_classid = 0x40; break;

NetDEF-CI avatar Feb 19 '23 09:02 NetDEF-CI

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found
Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found
Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found
Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: No useful log found
Successful on other platforms/tests
  • FreeBSD 12 amd64 build
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • Fedora 29 amd64 build
  • FreeBSD 11 amd64 build
  • CentOS 7 amd64 build
  • Redhat 9 amd64 build

NetDEF-CI avatar Feb 19 '23 10:02 NetDEF-CI

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found
Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found
Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: No useful log found
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found
Successful on other platforms/tests
  • FreeBSD 12 amd64 build
  • Fedora 29 amd64 build
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • CentOS 7 amd64 build
  • FreeBSD 11 amd64 build
  • Redhat 9 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found
Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found
Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: No useful log found
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found 
Report for bgp_qppb_private.c | 8 issues
===============================================
WARNING: Block comments use a trailing */ on a separate line
#24: FILE: /tmp/f1-1958723/bgp_qppb_private.c:24:
+ * }; */

ERROR: space prohibited before that close parenthesis ')'
#90: FILE: /tmp/f1-1958723/bgp_qppb_private.c:90:
+		 .init = bgp_qppb_module_init, );
Report for bgp_route.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #10852: FILE: /tmp/f1-1958723/bgp_route.c:10852:
Report for bgp_zebra.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #1464: FILE: /tmp/f1-1958723/bgp_zebra.c:1464:
Report for dscp.c | 4 issues
===============================================
ERROR: space required after that close brace '}'
#21: FILE: /tmp/f1-1958723/dscp.c:21:
+	{"voice-admit", DSCP_VOICE}};
Report for routemap_northbound.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #1462: FILE: /tmp/f1-1958723/routemap_northbound.c:1462:
< WARNING: line over 80 characters
< #1463: FILE: /tmp/f1-1958723/routemap_northbound.c:1463:
< WARNING: line over 80 characters
< #1467: FILE: /tmp/f1-1958723/routemap_northbound.c:1467:
Report for xdp_qppb.c | 149 issues
===============================================
ERROR: spaces required around that ':' (ctx:VxW)
#22: FILE: /tmp/f1-1958723/xdp_qppb.c:22:
+#warn XXX: Poor config
          ^

WARNING: C99 // comments do not match recommendation
#54: FILE: /tmp/f1-1958723/xdp_qppb.c:54:
+//               type : key :  leaf : name : size : pin_dir : flags

WARNING: line over 80 characters
#55: FILE: /tmp/f1-1958723/xdp_qppb.c:55:
+BPF_TABLE_PINNED("percpu_array", u32, struct datarec, xdp_stats_map, XDP_ACTION_MAX, STAT_PIN);

WARNING: line over 80 characters
#56: FILE: /tmp/f1-1958723/xdp_qppb.c:56:
+BPF_TABLE_PINNED("lpm_trie", struct lpm_key4, u8, dscp_map, 10240, DSCP_PIN, BPF_F_NO_PREALLOC);

WARNING: line over 80 characters
#57: FILE: /tmp/f1-1958723/xdp_qppb.c:57:
+BPF_TABLE_PINNED("array", u32 /*iface_id*/, u32 /*qppb_bgp_policy*/, qppb_mode_map, 64, QPPB_PIN);

WARNING: C99 // comments do not match recommendation
#58: FILE: /tmp/f1-1958723/xdp_qppb.c:58:
+//               XXX: choose table size limits (read them from sysctl?)

WARNING: Missing a blank line after declarations
#74: FILE: /tmp/f1-1958723/xdp_qppb.c:74:
+	struct datarec *rec = xdp_stats_map.lookup(&action);
+	if (!rec)

ERROR: code indent should use tabs where possible
#85: FILE: /tmp/f1-1958723/xdp_qppb.c:85:
+        __u32 check = bpf_ntohs((__be16)iph->check);$

WARNING: please, no spaces at the start of a line
#85: FILE: /tmp/f1-1958723/xdp_qppb.c:85:
+        __u32 check = bpf_ntohs((__be16)iph->check);$

ERROR: trailing statements should be on next line
#90: FILE: /tmp/f1-1958723/xdp_qppb.c:90:
+	if ((check+1) >> 16) check = (check+1) & 0xffff;

WARNING: Missing a blank line after declarations
#106: FILE: /tmp/f1-1958723/xdp_qppb.c:106:
+	struct meta_info *meta;
+	rc = bpf_xdp_adjust_meta(ctx, -(int)sizeof(*meta));

ERROR: code indent should use tabs where possible
#128: FILE: /tmp/f1-1958723/xdp_qppb.c:128:
+                goto aborted;$

WARNING: please, no spaces at the start of a line
#128: FILE: /tmp/f1-1958723/xdp_qppb.c:128:
+                goto aborted;$

WARNING: line over 80 characters
#137: FILE: /tmp/f1-1958723/xdp_qppb.c:137:
+		bpf_trace_printk("XDP ignore marked packet [%d|%d]", iph->tos, meta->mark);

ERROR: switch and case should be at the same indent
#163: FILE: /tmp/f1-1958723/xdp_qppb.c:163:
+	switch (qppb_mode) {
+		case BGP_POLICY_DST:
[...]
+		case BGP_POLICY_SRC:
[...]
+		default:

WARNING: char * array declaration might be better as static const
#191: FILE: /tmp/f1-1958723/xdp_qppb.c:191:
+	const char *MODES[] = { "MARK_SKB\0", "MARK_META\0", NULL };

WARNING: Missing a blank line after declarations
#192: FILE: /tmp/f1-1958723/xdp_qppb.c:192:
+	const char *MODES[] = { "MARK_SKB\0", "MARK_META\0", NULL };
+	bpf_trace_printk("Mode [%s]\n", MODES[0]

WARNING: space prohibited between function name and open parenthesis '('
#195: FILE: /tmp/f1-1958723/xdp_qppb.c:195:
+	Lookslike bpf version of printk handles only first string arguments (?)

ERROR: spaces required around that '?' (ctx:BxB)
#195: FILE: /tmp/f1-1958723/xdp_qppb.c:195:
+	Lookslike bpf version of printk handles only first string arguments (?)
 	                                                                     ^

WARNING: C99 // comments do not match recommendation
#197: FILE: /tmp/f1-1958723/xdp_qppb.c:197:
+		https://nakryiko.com/posts/bpf-tips-printk/

ERROR: spaces required around that ':' (ctx:VxE)
#197: FILE: /tmp/f1-1958723/xdp_qppb.c:197:
+		https://nakryiko.com/posts/bpf-tips-printk/
 		     ^

ERROR: spaces required around that ':' (ctx:VxW)
#200: FILE: /tmp/f1-1958723/xdp_qppb.c:200:
+out:     return xdp_stats_record_action(ctx, action);
    ^

WARNING: C99 // comments do not match recommendation
#202: FILE: /tmp/f1-1958723/xdp_qppb.c:202:
+aborted: return xdp_stats_record_action(ctx, XDP_ABORTED);  // packet is dropped

ERROR: spaces required around that ':' (ctx:VxW)
#203: FILE: /tmp/f1-1958723/xdp_qppb.c:203:
+skip:    return action;
     ^

WARNING: C99 // comments do not match recommendation
#212: FILE: /tmp/f1-1958723/xdp_qppb.c:212:
+	// Default priority

WARNING: C99 // comments do not match recommendation
#214: FILE: /tmp/f1-1958723/xdp_qppb.c:214:
+	// Check XDP gave us some data_meta

ERROR: "(foo*)" should be "(foo *)"
#215: FILE: /tmp/f1-1958723/xdp_qppb.c:215:
+	if ((void*)(meta + 1) > data)

ERROR: switch and case should be at the same indent
#222: FILE: /tmp/f1-1958723/xdp_qppb.c:222:
+	switch(meta->mark >> 2) {
+		case 10: skb->tc_classid = 0x10; break;
+		case 20: skb->tc_classid = 0x20; break;
+		case 30: skb->tc_classid = 0x30; break;
+		case 40: skb->tc_classid = 0x40; break;

ERROR: space required before the open parenthesis '('
#222: FILE: /tmp/f1-1958723/xdp_qppb.c:222:
+	switch(meta->mark >> 2) {

ERROR: trailing statements should be on next line
#223: FILE: /tmp/f1-1958723/xdp_qppb.c:223:
+		case 10: skb->tc_classid = 0x10; break;

ERROR: trailing statements should be on next line
#224: FILE: /tmp/f1-1958723/xdp_qppb.c:224:
+		case 20: skb->tc_classid = 0x20; break;

ERROR: trailing statements should be on next line
#225: FILE: /tmp/f1-1958723/xdp_qppb.c:225:
+		case 30: skb->tc_classid = 0x30; break;

ERROR: trailing statements should be on next line
#226: FILE: /tmp/f1-1958723/xdp_qppb.c:226:
+		case 40: skb->tc_classid = 0x40; break;

NetDEF-CI avatar Feb 19 '23 10:02 NetDEF-CI

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Mar 22 '23 17:03 github-actions[bot]

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

github-actions[bot] avatar Sep 19 '23 01:09 github-actions[bot]

Still WIP, don't close

volodymyrhuti avatar Oct 01 '23 16:10 volodymyrhuti

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 11 '23 05:10 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 01 '23 11:12 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 09 '24 15:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 30 '24 15:01 github-actions[bot]

Hi all! Sorry for taking so long with this feature. My team is looking forward to this getting merged. @riw777, @donaldsharp could you dedicate some time to reviewing my changes? Thank you in advance!) As well, I have prepared a GNS demo and will share the link over Slack.

Regarding the patch set size:

- Commit `bgpd, zebra, tests: move plugin down to zebra` is a separate commit for now.
I have made this change on @donaldsharp's request from the dev meeting.
The plan is to squash it across the relevant commits after the review.

- The last commit `tests: implement dscp -> vrf packet switching demo` is there to display what I had progressed on.
Once the feature is approved, I will drop it from this patch set and upload it separately.

volodymyrhuti avatar Mar 18 '24 15:03 volodymyrhuti

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Mar 26 '24 14:03 github-actions[bot]

So first questions: why BGP?

I tend do think that QPPB is already supported by other customers. https://www.noction.com/blog/qos-policy-propagation-via-bgp-qppb

pguibert6WIND avatar Mar 27 '24 20:03 pguibert6WIND

In this proposal, the BGP protocol is not involved at all - BGP just acts as the host for a routemap.

To me, this feels like an ... experiment, a demo, a proof-of-concept - and that's fine, that's up to vyos. But it may not be a good proposal for FRR.

So first questions: why BGP?

I tend do think that QPPB is already supported by other customers. https://www.noction.com/blog/qos-policy-propagation-via-bgp-qppb

mjstapp avatar Mar 28 '24 12:03 mjstapp 

It proposes adding an XDP/kernel module - isn't that what that is? It proposes
making some meaningful changes to the topotest infrastructure, and adding some
very OS-specific test code.

This PR includes:

  • plugin to access bpf mappings
  • XDP hooks (200 line C files) compiled/attached by bcc/tc
  • extension of bgp_attr/route map struct
  • reference Cisco topology + QOS setup in topotest
  • a functional test for the XDP hooks (modifying bpf mappings, the OS-specific test code) This PR shows how to interact with BPF and XDP from the FRR routing stack.
Why not ... run the routemap in zebra, for example?
BGP cli that shows this new dscp value, but no zebra show output?
In this proposal, the BGP protocol is not involved at all - BGP just acts as
the host for a routemap.

So the first intuition is that QPPB is QoS over BGP. I have looked into the bgpd. Although I understand what you are talking about, I can move the routemap logic + cli show cmd down to zebra. Is this a reasonable change?

On the zebra side, it appears that a synchronous call is made

This hook performs a write operation in the bpf map (LPM [prefix, dscp]) using bpf_map_update_elem api. If that is your concern, I expect no serious performance overhead for this operation.

Similarly, we have a plugin-based dataplane subsystem in zebra that is intended
to offload OS-specific communication. I'd prefer to see how that layer could be
used or extended to support new dataplane features.

What would be a better place to call my plugin from data plane subsystem? I'm going to research this, and advice would be helpful)

To me, this feels like an ... experiment, a demo, a proof-of-concept - and
that's fine, that's up to vyos.

Sure, that is no problem. But would it be possible to define a minimal list of changes that you would like for this feature to become applicable for FRR. I would be glad to fix things up. I have also prepared a demo, which I am going to share over Slack.

volodymyrhuti avatar Apr 03 '24 22:04 volodymyrhuti

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 13 '24 14:05 github-actions[bot]