Eigrp #11301 - Configuration failed error type: validation

[volodymyrhuti]

For more details, please look at: https://github.com/FRRouting/frr/issues/11301#issuecomment-1753246744 Additional context: https://vyos.dev/T5737

[volodymyrhuti]

Not sure if I need to fix the CI warnings, it is not dangerous to ignore identifier names for function declarations in the header. Unless maintainers would like me to handle this.

[donaldsharp]

The rule is that you don't have to fix something you don't touch but if you add new code it must conform to our standard. The tool is telling you about the problem

[volodymyrhuti]

Regarding missing documentation - it is already present.

eigrpd.rst:
----------------------------------------------------------------------------------------------
.. clicmd:: passive-interface (IFNAME|default)

   This command sets the specified interface to passive mode. On passive mode
   interface, all receiving packets are ignored and eigrpd does not send either
   multicast or unicast EIGRP packets except to EIGRP neighbors specified with
   `neighbor` command. The interface may be specified as `default` to make
   eigrpd default to passive on all interfaces.

   The default is to be passive on all interfaces.

I have fixed the CI warnings and will check if somebody from my team can assist with the test case.

[riw777]

not certain we need a topo test here?

[riw777]

@volodymyrhuti if we can get the invalid interface bits fixed, we can merge this, I think ...

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[riw777]

Is anyone still working on this?

[riw777]

@frrbot autoclose in 1 month

[volodymyrhuti]

@riw777 sorry for not following up on this one. I believe it is still relevant and applicable I ignored it as I was expecting extra help with testing from the team. At the moment, I`m not more associated with VyOS, so the testing part is irrelevant now. If you think it looks good, I will find a time next week to rebase and run it locally.

[frrbot[bot]]

This issue will no longer be automatically closed.