Dominik Moritz

Results 1544 comments of Dominik Moritz

Hi @drgould, do you plan to finish this pull request?

Oh, that's awesome to hear. Congrats on launching the feature 🎉 . If you want, you can send a pull request to add it to https://vega.github.io/vega-lite/ecosystem.html. More generally, I would...

@wmarques yes, I won't have the cycles to implement this but I can review a pull request. Could you open a new pull request with this code and any improvements...

Thank you for offering to help. I look forward to your contributions.

Just wanted to check in to see whether you need any help with getting this over the finish line. Please mark the pull request as ready for review when you...

The example generation depends on specifics of the OS so we usually let the ci do it (see contributing docs). If the ci doesn't do it for you, can you...

Can you try setting a `GH_PAT` in your repo secrets of your fork? If it doesn't work, I can copy your branch into this repo when you think it's ready....

I copied the pull request to our repo over at https://github.com/vega/vega-lite/pull/7356 so we can build the examples.

@drgould is there anything I can help with to get this pull request over the finish line?

No, this is for faceted charts only. We already support single view and layered plots.