Dominik Moritz

Results 1544 comments of Dominik Moritz

Thank you for making small examples. it really helps isolate issues and see whether this is a duplicate or a new issue.

If you want to help further debug this issue, could you take a look at the generated Vega and see whether you can find where Vega-Lite generates incorrect Vega?

Depends on https://github.com/vega/vega/issues/2233

Sweet, thank you. I think the workflow with vscode dev.m containers is really nice and already well documented.

I redid the setup with a standard dev container (using vscode) in https://github.com/vega/vega-lite/pull/7809. I also added a test. What do you think?

What do you think about the proposal in #7809? I tried to use the template from dev containers and made a slightly slimmer setup. Could you help finish it up?

Just tried the latest and it fails ``` [519 ms] Remote-Containers 0.205.2 in VS Code 1.62.2 (3a6960b964327f0e3882ce18fcebd07ed191b316). [519 ms] Start: Resolving Remote [521 ms] Setting up container for folder or...

Please run `yarn format` @behrica

The docker test is failing: https://github.com/vega/vega-lite/runs/4253502607?check_suite_focus=true.

Can you merge the last two commits? Somehow the tests don't run.