Dominik Moritz
Dominik Moritz
Thanks for the detailed response. I agree with all your comments and look forward to the improvements. Either way, they will be significantly better than what we have right now.
Overall, really excited about this addition. I love the examples and how snappy they are. - [ ] When running `VegaProgressivis`, I get `ModuleNotFoundError: No module named 'progressivis'`. I think...
Thank you for the updates. I added another set of comments. This is looking good and I am confident we can merge it when you address the comments.
Let me know when this is ready for another review pass. Looking forward to making this available to our users.
If Altair is only a dependency for tests and a notebook, it should be a dev dependency only, right?
The issue is that `Pick%3CBaseInterface%2CExclude%253C(%2522field1%2522%257C%2522field2%2522%257C%2522field3%2522)%252C(%2522field1%2522%257C%2522field3%2522)%253E%3E` is pretty difficult of a name. It would be great to come up with a simpler naming scheme for anonymous types.
I am fixing the example in https://github.com/vega/ts-json-schema-generator/issues/276#issuecomment-563045632
I'd say mode skewness should compute the correct thing so 2. But we could keep the existing function around but with a different name, which is 1. And while you're...
Why a new pull request? You can push to the branch you made your other pull request from and it'll update.
This is the same pull request now. Please dort force push next time since it makes it hard to review for me.