Dominik Moritz

Results 1544 comments of Dominik Moritz

Sounds good. Let me also mention that Vega-Lite would benefit from having support for conditionals so I am very much looking forward to having support for it.

Yes, we intentionally don't support functions. See for some reasons why not: https://github.com/vega/ts-json-schema-generator/issues/98

I'm happy to review a pull request.

I recommend listening to the signal of the name of the selection. Also follow https://github.com/vega/vega-lite/issues/2790 cc @arvind

So the idea is to never output something of the form ``` "XXXX": { "$ref": "#/definitions/YYYY" } ``` and replace all occurrences of XXXX with YYYY

This works as expected. We output intermediate aliases when they are exported. You can hide a alias by not exporting it: ``` export interface Parent { a: A; } export...

Hmm, I guess we could use the `@hide` annotation here to skip aliases. I don't think hiding an alias that's only used once is a good idea since it may...

Yep, we only respect `@hide` for properties right now. I suggest that we also use it to ignore aliases. Would that be the solution that we want?

It doesn't. We only use it for properties of objects and interfaces.