Dominik Moritz
Dominik Moritz
You make a fork, push to your fork, send a pull request from there. You have full permissions to push to your fork.
As discussed in https://github.com/vega/ts-json-schema-generator/pull/2073#issuecomment-2357262748, we want a simple behavior here and https://github.com/vega/ts-json-schema-generator/issues/1899#issuecomment-2356131944 is a great solution for anyone who needs special behavior.
I think the easiest solution is to convert to number early and error when the bigint is too large.
Be careful. Number does not fail for large bigints. In arrow I wrote a safe version that checks that the bigint isn't too big.
I don't see a problem if we make sure that there is no faceting into columns at any level.
What I mean is that if you want to fit on x, then you have to ensure that no view (no matter how deeply nested) facets horizontally.
@willium do you want to integrate a patch?
Thanks for the report. Can you provide a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) that demonstrates the issue?
That's not yet minimal if you can remove anything and the error state does not change. Oncer you identify the offending change, you can see how it's causing the issues...
Flagging @kristw and @kanitw for react-vega.