Dominik Moritz
Dominik Moritz
Why should embed do this and not Vega or Vega-Lite? I see that the information is here and not in Vega-Lite but it feels odd.
The problem with lines and missing values is a separate issue. It's not clear what the right behavior for a line chart is. One option is to not draw a...
In @mccalluc's case, we want to impute 0. I can imagine that you want other values in other cases. It's hard to generalize.
I think it'd e great to pass the impute through to vega.
I think this is a bug in the Vega binning and specifically a floating point issue. Related issues * https://github.com/vega/vega/issues/830 * https://github.com/vega/vega/issues/2227 * https://github.com/vega/vega/issues/1737 * https://github.com/vega/vega/pull/2228 * https://github.com/vega/vega/issues/2181
The behavior in other cases seems to be that the end of the extent is included in the last bin. For example in https://vega.github.io/editor/#/url/vega-lite/N4IgJAzgxgFgpgWwIYgFwhgF0wBwqgegIDc4BzJAOjIEtMYBXAI0poHsDp5kTykBaADZ04JAKyUAVhDYA7EABoQAEySYUqUAwBOgtCrVICCNsRpwIUmfIC+S5NoDW+pkm2KQcWVDbKassjRQAA8gkCZ-NExtBjglADNzQWV9ACU2bC8AAgAVNmRMNgss1LV-QLsQAE8wpDIybT5MOH0fBllMEBtuoA, 10 is included in the last...
Okay, I think I found the issue. For the example above, in https://github.com/vega/vega/blob/938abf2d7226302ebec2dc4e74bc363d0e271c6b/packages/vega-transforms/src/Bin.js#L100, the step size is 0.1 and the start is `-0.30000000000000004`. Together with the `EPSILON`, this breaks. ```js...
The logic for adjusting the bin end is from https://github.com/vega/vega/pull/2182 which fixes https://github.com/vega/vega/issues/2181. It breaks here where we have to deal with floating point numbers for the bin start which...
```json { "$schema": "https://vega.github.io/schema/vega-lite/v5.20.1.json", "data": {"values": [{"x": 0}, {"x": 29}]}, "mark": {"type": "rect", "tooltip": true}, "encoding": {"x": {"bin": {"maxbins": 10, "nice": false}, "field": "x"}} } ``` Which isn't great because...
We should think about pluggable data loaders. We already have an arrow loader but zarr could be interesting as well once we support this feature here. Bundle size is always...