Dawa Ometto

This PR adds support for the MermaidJS diagram rendering library. Both GitLab and GitHub now support Mermaid, so this is a feature that would increase compatibility. ### Approach 1. This...

See https://github.com/gollum/gollum-lib/pull/420 - [ ] Compile static assets

Update to Sprockets 4

3

See https://github.com/rails/sprockets/issues/565#event-2696215187 This will also allow migrating to `SassC`, as the old ruby `sass` gem is deprecated.

Sandbox mode results in invalid document on parse errors

9

When using `securityLevel: 'sandbox'`, a parse error in a diagram results in a *second* iframe with exactly the same ID as the first (correctly placed) iframe, thus rendering the main...

Jruby Support

3

The docs state that `jruby` is currently not supported, but I can `gem install mustermann` just fine. Is it ready for use with `jruby` after all? I have tried to...

Update octicons

3

Looked at the breaking changes for `octicons` since v.12: ``` THIS IS A BREAKING CHANGE and will require re-linking all the file-directory icon references to file-directory-fill • Rename 16px select-single...

It turns out `commonmarker` by default removes HTML tags from markdown for safety. Since we already implement our own sanitization, this seems superfluous: indeed, other renders such as `kramdown` already...

Improve code filter performance

1

I thought I saw an opportunity for improving the performance of the code filter. Instead of calling `data.gsub!` for every `id` in `@map`, we can call `data.gsub!` only once, and...

At the moment, we are calling `sanitize(data)` in the filter chain (at least) twice: in the actual `Sanitize` filter, and inside the `Macro` filter, to counter an exploit discovered a...

Add support for kramdown options

2

For `commonmarker`, it is already possible to pass in parsing and rendering options in the `GitHub::Markup.render` call, e.g.: ```ruby GitHub::Markup.render("test.md", "hello world", options: {commonmarker_opts: [:UNSAFE]}) ``` This PR adds support...