Dawa Ometto

Ace-Diff proof of concept

1

A proof of concept for merge functionality using the ace-diff library. Run gollum with `--development-assets`, open an editor, and execute the following JS for a very basic diff view: ```js...

HTML escape YAML after parsing to prevent invalidating YAML string

3

Resolves https://github.com/gollum/gollum/issues/2024 We were previously HTML escaping the entire YAML string before parsing it. This means that some valid YAML was being scrubbed (in the case of the reported bug,...

Relies on https://github.com/gollum/rugged_adapter/pull/64 This begins work on a fix for https://github.com/gollum/gollum/issues/1975. The `WorkdirModifiedError` is thrown whenever a file in the workdir has modifications, or is new -- and we then...

Rethink logic for Macro sanitization

2

Currently individual Macros have to call `CGI.escapeHTML` on user-supplied input. I am wondering whether it makes sense to instead sanitize the parameters that are passed to each individual Macro [here](https://github.com/gollum/gollum-lib/blob/master/lib/gollum-lib/filter/macro.rb#L26)....

Please file issues at [grackorg/grack](https://github.com/grackorg/grack)

HTML5 empty attributes are being scrubbed

5

https://github.com/flavorjones/loofah/commit/a6922ce26eaddaa4d638b5df66c018d002d33b75 seems to have had the effect of scrubbing valueless attributes even if they are in `SafeList`. For example, even after adding `controls` to the `SafeList` with: ```ruby Loofah::HTML5::SafeList::ALLOWED_ATTRIBUTES.add('controls') ```...

Should be: ``` ${gempath}/passenger-${version}/buildout/apache2/mod_passenger.so ``` instead of ``` ${gempath}/passenger-${version}/ext/apache2/mod_passenger.so ``` ...both in the exec running passenger-install-apache and in the file defining the contents of passenger.load

Support prebuilt client

2

Resolves #207 This PR: 1. Adds optional support for deploying the prebuilt client in `client.yml`. 2. Splits up the installation of node and yarn into a new includes file so...

Implements the method defined in https://github.com/gollum/adapter_specs/pull/18. This PR should be rerun against the specs when https://github.com/gollum/adapter_specs/pull/18 is merged. The purpose of this method is to aid in solving https://github.com/gollum/gollum/issues/1975

Rename Blob#is_symlink

3

The RJGit version is called `#is_symlink?`, which is more idiomatic. This should be added to the adapter specs, too.