Guillaume Doisy
Guillaume Doisy
Thanks for the PR, it seems to generate nice smoothed cmd vel. However I believe there is a bug with the `rotating_` globlal variable. When rotating at the end of...
Your last PR fixes the rotation bug, thx.
You should probably make your new parameters dynamic similarly to the others
@angstrem98, this PR is promising, any update ?
> > Perhaps some of this work doesn't need to be done in RPP itself but in the velocity smoother #2633 that interacts at the lower-levels that can be tuned...
I still cannot believe that close to 5 months after the last ROS2 LTS release, its default DDS implementation is not yet fully functional ! I moved away to Cyclone...
Friendly ping @MichaelGrupp, can you have a look? We are ready to take care of the rviz part next. Is there anybody maintaining the project ? We would be okay...
18/11/2021 update: rviz is now supported thanks to the efforts of @imstevenpmwyca Our next project will be to make the cartographer ros node a lifecycle but first this PR should...
> First of all, this is fantastic work. This is what we've been waiting for to move cartographer forward for quite a while. > > I'm not a maintainer here,...
28/11/2021 update: - deboostify - replace RCL_SYSTEM_TIME by RCL_ROS_TIME in asset_writer - some tf warning fix in carto rviz - some compilation warning fixes for unused variables (and comments/TODO added)...