Dominic Evans

Results 280 comments of Dominic Evans

In this most recent log it looks like you’ve put the comma separated three broker addresses in the config as a single string rather than as a slice of strings...

@kbsivacse have you checked kafka broker logs?

Sarama doesn’t pull x/crypto as a direct dependency. We get it as an indirect dep via https://github.com/jcmturner/gokrb5 and so as a library we can’t control its version. We either need...

Yes it was me who submitted the PR to bump it originally [here](/jcmturner/gokrb5/pull/459), but I was awaiting a tagged release before bumping the dependency

As mentioned on that PR, it’s really a false positive because the ssh pkg isn’t used at all, so is only flagged by vuln scanners which don’t look at the...

@k-wall yes this sounds like an excellent plan

No they're equally likely to hit a condition of `ErrNoController` so you're correct that they should really be wrappered in a similar `ca.retryOnError(isErrNoController, ...) { ... }` call

@boralt some questions 1. I'm not sure what you mean by "old" as the timestamps of these log lines are very close together, is the generationID just getting bumped due...

So the client does already run a periodic metadata refresh based on backgroundMetadata goroutine in client.go which ticks on `client.conf.Metadata.RefreshFrequency` which defaults to 10m so you could reduce that to...

@talbspx interesting. If it's just local single broker instance can you change the idle broker config to 2m, set Sarama to 60s refresh and enable debug logs on the broker...