Dominic Evans

Results 280 comments of Dominic Evans

@chaithraav see the release notes for [v1.41.0](https://github.com/IBM/sarama/releases/tag/v1.41.0), but ultimately we started to implement support for more features of the newer kafka protocols and hence our adherence to the use of...

Yeah the latter I think. @vladoatanasov spotted the original problem whilst using the decoder code elsewhere. I was mildly surprised we'd never hit any problems due to this, but I...

@puellanivis yeah I think I intended to come back and add a unittest before getting a review and merging, but obviously forgot about it

@Sergey-Belyakov thanks for the PR, this is interesting! Will take a look to see what the Java client behaviour is in this scenario to ensure we align

@kgatv2 what is your backend cluster? We just need to be clear _why_ we think the FetchResponse that isn't end-of-topic, has no error and no records – to ensure we're...

@sterligov thanks this is good analysis. I think you’re probably right and the original fix attempted under https://github.com/IBM/sarama/pull/2057 was put in the wrong place and should have used your delta...

closing in favour of merged https://github.com/IBM/sarama/pull/3221 – thanks for raising the issue!

@zornhsu don't worry, we will get to it in time. I had partially been waiting to see what feedback the upstream apache/kafka PR received, but that has still not yet...

@ijuma (seeing as I have you nearby) do you have any thoughts on this? The KIP and this PR both some like they provide a reasonable feature and the motivation...

Sure, have added a commit to fix that. During testing I also noted that the doReloadTabs on the released version on the firefox store had inadvertently filtered-in discarded tabs rather...