Dominic Evans

Results 280 comments of Dominic Evans

closing as presumed fixed based on https://github.com/IBM/sarama/issues/1771#issuecomment-1155049404

@MoilkNepho did you resolve this issue with newer versions or is it something you still see occurring?

With `connections.max.idle.ms ` enabled server side, this _should_ have been fixed with https://github.com/IBM/sarama/pull/2197 and https://github.com/IBM/sarama/pull/2234 both merged @david-bergman it sounds like you are still seeing issues — I wonder if...

@tuliogomesbarbosa @Siyu-silvia are you still seeing this behaviour with modern Sarama versions? There were a bunch of fixes and improvements in this area of code over time.

Fixed by https://github.com/IBM/sarama/pull/2329

Closing as fixed by https://github.com/IBM/sarama/pull/2387

This PR was superseded by https://github.com/IBM/sarama/pull/2482 which is waiting for more testing feedback from AWS users and the /v2 version boundary of Sarama (because it will change the client API...

Believed to be fixed by https://github.com/IBM/sarama/pull/2378

i.e., https://github.com/IBM/sarama/blob/dedd86d84f2d56a7c3b604ea36da479c3d2a80bb/examples/consumergroup/main.go#L180-L204