David Reiss

Results 65 comments of David Reiss

> Yeah, it's less about requiring multiple files but that multiple files are supported and there's a concept of an environment that's not ideal to expose in the interface IMHO....

> ## Potential risks > There is a very slim chance that some configuration files might accidentally have some text that looks like go template, which the code would now...

I think if you do this in the obvious way, it'll create more problems. Like if you block on the rate limiter after a task is assigned to a poller,...

For 1 (returning the token after delivery failure), it turns out that the rate limiter doesn't support canceling a reservation after its time has passed, so the logic would have...

I've seen this before on the worker service. I'm not sure why we would recreate grpc.ClientConns since we have a stub-level cache that should avoid creating new ones. The new...

> Can we create a separate workflow file for this purpose? `run-tests.yml` is complicated enough that adding this seems added complexity unnecessarily. Also, as you noted, running `misc-checks` is also...

Sync match isn't prioritized over backlog right now. They both write into one go channel. I suppose the ratio will be tilted toward sync match since there could be multiple...

The config flags are weird for historical reasons. `-c` is a global flag (i.e. has to be given before `start`), but it just specifies the directory. For the file within...

I'd also like the ability to (selectively) delete media. I did a pass and deleted old media on Android recently to reduce the backup size, and I'd like to be...

I'm still interested in this feature. (I get the idea of a stale bot for closing old unreproduceable crashes and stuff, but it's kind of insulting when applied to clearly...