David Reiss
David Reiss
> This PR has a delta of nearly 8000 changed lines (I'm lazily summing additions and subtractions). > > Can you break this PR into a stack for your reviewers...
> That'll work. I appreciate it I force-pushed with a split into 5 commits. I haven't merged with recent changes on main (new settings, mostly), I'll do that all at...
I tried this out here: https://github.com/dnr/npmlock2nix/tree/reorganize It needs some more polishing but it works for me, and personally I find this API easier to understand: The attributes for the three...
It's ironic because I prefer `lower_with_underscores` style to `camelCase`, but I prefer consistency even more :) I'm not actively working on my node project at the moment, so I'm not...
Hi, really sorry about the delay on this one. In general I think the code is great, there's two general reasons I haven't merged it yet: First, we don't have...
Hi @belokrylov, would it be acceptable to allow overriding those two header names (in static config), or do you want the ability to examine an arbitrary number of headers? The...
Could you check if PR #4935 works for you? This lets you add a `authHeaderName` and `authExtraHeaderName` in your static config to change the header names to look up.
Would you be able to use this feature? https://github.com/temporalio/temporal/blob/4be14dd3308031219db02945a12a2cf7d29614b3/common/authorization/claim_mapper.go#L60-L65 You can implement `AuthInfoRequired` and return `false` and the ClaimMapper will be called in all cases. (I know it's a little...
There's a bunch of unrelated stuff on this pr so it'll take a while, or should be split. First just high level comments: > * Replaced package `tqname` with `taskqueue`...
Old ips in `cluster_membership` are expected and harmless. They're only used to bootstrap ringpop and then ringpop is used for membership information. Only rows that were updated in the last...