David Reiss

Results 65 comments of David Reiss

That looks like the change to the status of the schedule workflow hasn't made it to visibility. Which main and visibility backends are you using? Have you noticed any other...

> I didn't quite finish the review and had a hard stop. I would be calmer accepting this if we had ndc/xdc tests that show the build IDs being propagated...

It'd be a totally reasonable request to fix that on the server side instead

Updating search attributes and memos on schedules isn't supported yet. See https://github.com/temporalio/temporal/issues/4858 (that's about search attributes but they're handled very similarly so we'll do memo at the same time)

For memo in list results, it's available in the protocol but correct, not exposed in the cli yet. That should be easy to add.

We decided a while ago that dropping client-side batch is fine. We can add more features to server-side batch as requested (and tctl still exists in the meantime).

> Your protogen version is out of date as we pin protogen in the makefile; it's separate from the Go API version in go.mod I know, I'm waiting to do...

> > What will happen to the CLI dev server? > > I am explicitly setting cli dev server cache size to be 8k in dynamic config yaml file: [#5894...

I tried two similar extensions and they didn't work either, unfortunately. One of them claimed to support bookmarklets, so I suspect it might be a fairly recent Chrome security change....

I removed the buf upgrade from this PR. I couldn't get buf 1.32.2 to respect a config file (to change the compatibility level and add ignores) when using binpb inputs...