dnlup

Results 54 comments of dnlup

I am trying to figure out the test failures, maybe I should mark this draft as ready to run tests in the CI. This implementation is the one that makes...

I've looked into this lately, and I agree with you, the downside of this approach is that we have to use the generics in every point we need it 🤔...

The problem with the `timerify` function. should be solved (https://github.com/nodejs/node/pull/43330), but I don't think this PR is a priority,. Maybe we could start from scratch if/when needed.

I think we can close this one now.

After some experimenting, it turns out that SSR is not well supported in `docsify` atm, leaving GH pages as the remaining option. At least until https://github.com/docsifyjs/docsify/pull/1227 is merged.

Hi @arthurfiorette , I am not familiar with Sentry SDK in electron environments. Using another `@sentry/*` package would require the use of dynamic imports in the plugin code I think,...

Hi @spaceemotion , thank you for reporting this. `username` should definitely be optional, that's how it's handled too (https://github.com/immobiliare/fastify-sentry/blob/598a4dc1332a7a2dc99a347d8c9e72a3b29718b2/utils.js#L77). would you like to open a PR to fix that type?

> @dnlup would that make all keys optional then? some people might only have the ID, some only the username... @spaceemotion Yes, all the keys should be optional

Hi @GlenTiki , thank you for the suggestion. It seems interesting but I am not sure I understand correctly . Can you share a poc implementation or an event screenshot...

Thank you @GlenTiki and @tomasstrejcek for the detailed description, I see the use case for this but I am not sure if it should be implemented in this plugin though....