node
node copied to clipboard
WIP net: enable emitclose in socket
This is a WIP. It might take a while.
This PR should enable emitClose
in net.Socket
, ideally without changing any tests.
Fixes: #36636
Checklist
- [ ]
make -j4 test
(UNIX), orvcbuild test
(Windows) passes - [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows commit guidelines
@dnlup nit: I think it should be: ~Ref: https://github.com/nodejs/node/issues/36636~ Fixes: https://github.com/nodejs/node/issues/36636
Yup, thank you @RaisinTen
I am trying to figure out the test failures, maybe I should mark this draft as ready to run tests in the CI. This implementation is the one that makes more sense to me atm.