dnlup
dnlup
> @dnlup Are there any breaking changes for us ? There is that standing issue about the web assembly dependency that fails to install on some machines.
The tests are failing for other reasons. I'll fix that.
> > The tests are failing for other reasons. I'll fix that. > > No tests are failings, I just wanted to know if there are any breaking changes in...
I would mark this as a breaking change though.
Yes that is useful 😉
> I've missed a point in this that I haven't thought before and there is only one thing to keep in mind, this will never be a 100% correct timing....
A couple of thoughts: 1. maybe it could be useful to expose this also for sync functions 2. if the function that we want to time is attached to a...
Sure, imagine we have to time something like: ```js fastify.decorate('someFn', function (arg1, arg2) { this.log.info(arg1,arg2) }) fastify.timeAsync(fastify.someFn, arg1, arg2) ``` I think we would lose the `this` context in the...
Finally found this: https://nodejs.org/dist/latest-v16.x/docs/api/perf_hooks.html#performancetimerifyfn-options We could provide a wrapper of this in the plugin, but I think it's also pretty straightforward to use as it is. I think it's a...
I have used it to track GC activity in the past with no perf issues, but I'll test it again for sure.