Dan Field comments

Results 553 comments of


                                            Dan Field

Avoid object creation during each frame

@simonla this needed a second reviewer, I've approved. Asking for a NTE from @Hixie

add thumbnails to the books example to make memory leaks easier to test

Perhaps it wants to be against main?

WIP cross compile wasm

This patch seems to have some confusion around its merge/rebasing history so it's really hard to read. Maybe if it was cleaned up I'd understand some of the motivation behind...

`testing_app` hangs on Windows

@cbracken might be better set up to help with this (or know who is). My access to Windows machines is fairly limited

Fix PlatformView multiple pointer crash caused by toMotionEvent

The test for this would be similar to `itUsesActionEventTypeFromFrameworkEventForVirtualDisplays` in `PlatformViewsControllerTest.java`. Do you think you can take that on?

Fix PlatformView multiple pointer crash caused by toMotionEvent

/cc @stuartmorgan FYI

Fix PlatformView multiple pointer crash caused by toMotionEvent

Try merging or rebasing on `main` - it looks like there may have been changes in CI since you branched that are incompatible.

Fix PlatformView multiple pointer crash caused by toMotionEvent

@stuartmorgan or @iskakaushik would you mind providing a second review here?

Error running perf_test in the testing_app sample

This should work. Seems like the host side isn't connecting to the device side properly

Error running perf_test in the testing_app sample

Ah! The problem here is that DDS is enabled. We should probably call that out if this error occurs. Can you try the command again with `--no-dds`?