engine icon indicating copy to clipboard operation
engine copied to clipboard
verified publisher icon flutter

WIP cross compile wasm

Open harryterkelsen opened this issue 3 years ago • 2 comments

WIP

Pre-launch Checklist

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [ ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I signed the CLA.
  • [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

harryterkelsen avatar Apr 07 '22 19:04 harryterkelsen

/cc @eyebrowsoffire

harryterkelsen avatar Apr 19 '22 18:04 harryterkelsen

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

flutter-dashboard[bot] avatar Jun 07 '22 23:06 flutter-dashboard[bot]

This patch seems to have some confusion around its merge/rebasing history so it's really hard to read. Maybe if it was cleaned up I'd understand some of the motivation behind the buildroot patch better.

dnfield avatar Sep 07 '22 16:09 dnfield

This patch seems to have some confusion around its merge/rebasing history so it's really hard to read. Maybe if it was cleaned up I'd understand some of the motivation behind the buildroot patch better.

Yes, bad merge. I'll clean this up and it should help clarify what I'm trying to accomplish with the buildroot PR.

harryterkelsen avatar Sep 07 '22 20:09 harryterkelsen

PTAL @dnfield

harryterkelsen avatar Sep 07 '22 21:09 harryterkelsen

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Sep 13 '22 20:09 flutter-dashboard[bot]